containerMode: kubernetes not taken into account on GitHub Enterprise 3.5.2

[bquenin]

Hi there!

We have deployed the latest version of ARC (0.25.2 as of the time of writing) and have registered our runner to our GitHub Enterprise instance version 3.5.2. We are facing the following issue:

The runner is configured as follow:

apiVersion: actions.summerwind.dev/v1alpha1
kind: Runner
metadata:
  name: bquenin-repository-runner
  namespace: actions-runner-system
spec:
  repository: bquenin/kind-actions
  containerMode: kubernetes
  serviceAccountName: runner-service-account
  workVolumeClaimTemplate:
    storageClassName: default
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 10Gi
  env: [ ]
  labels:
  - k8s-runner
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
  name: runner-role
  namespace: actions-runner-system
rules:
- apiGroups: [ "" ]
  resources: [ "pods" ]
  verbs: [ "get", "list", "create", "delete" ]
- apiGroups: [ "" ]
  resources: [ "pods/exec" ]
  verbs: [ "get", "create" ]
- apiGroups: [ "" ]
  resources: [ "pods/log" ]
  verbs: [ "get", "list", "watch", ]
- apiGroups: [ "batch" ]
  resources: [ "jobs" ]
  verbs: [ "get", "list", "create", "delete" ]
- apiGroups: [ "" ]
  resources: [ "secrets" ]
  verbs: [ "get", "list", "create", "delete" ]
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  name: runner-role-binding
  namespace: actions-runner-system
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: runner-role
subjects:
- kind: ServiceAccount
  name: runner-service-account
  namespace: actions-runner-system
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: runner-service-account
  namespace: actions-runner-system

We have tried the exact same deployment and register our runner directly to Github instead of our Github Enterprise instance and everything started to work like a charm.

As our Github Enterprise instance version is 3.5.2, can you please confirm that upgrading to version 3.6.0 or above (stated as a prerequisite in the documentation https://github.com/actions-runner-controller/actions-runner-controller#github-enterprise-support) will solve this issue?

[mumoshu]

@bquenin Hey! This reminds me of #1601 - your config looks good but the new container mode doesn't work.

I didn't think about the case in #1601 but I'm now wondering if your GHES version really supports the new container mode.

The requirement on 3.6.0 as written in https://github.com/actions-runner-controller/actions-runner-controller#github-enterprise-support is based on our usage of the newest flag added to the "list runner groups" API which, in GHES, is supported once after 3.6. It doesn't mean GHES 3.6 is tested with every feature.

And, I just realized that we've never tested the new container mode with GHES.
As far as I remember, GitHub added the backend for the new container mode on their side in May or June this year. It's very unlikely it's present in 3.5.x, right..? 3.6.x might have more chances.

If possible, could you try contact your GHES support for which versions of GHES include the Actions' server side feature for https://github.com/actions/runner-container-hooks ? It's the underpinning of the kubenetes container mode.

[bquenin]

Hi @mumoshu, thanks for your reply!

We will check with our GHES support to check in which version the Actions' server side feature has been rolled out.