Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge UI : Send token form should support deeplinking all URL params for a better UX #290

Open
dewanshparashar opened this issue Sep 19, 2022 · 2 comments
Assignees

Comments

@dewanshparashar
Copy link

Objective

For a seamless user experience, coming to https://across.to/ from other apps, most of the form data should be prefilled from the URL itself. https://across.to/?from=${from}&to=${to}&asset=${tokenSymbol}&amount=${amount}

Reproduce

URL: https://across.to/?from=ethereum&to=arbitrum&asset=eth&amount=100
Most of the values in the URL still render an empty form - making the user fill all the info again.

Code

In the code: frontend-v2/blob/master/src/hooks/uses Adform.tsx, we are extracting params.asset and params.amount from the URL using useQueryParams. However, these values are not being set automatically in the form during any point in the render cycle.

@james-a-morris
Copy link
Contributor

Thanks for raising this issue, @dewanshparashar. We'll internally review this to determine the best path of action on how to move forward.

@james-a-morris james-a-morris self-assigned this Sep 30, 2022
@james-a-morris
Copy link
Contributor

james-a-morris commented Sep 30, 2022

Hi, @dewanshparashar! I believe the reproducible issue you're facing is a result of an invalid link. The to and from fields require a valid numeric chainId.

To produce the intended UI state, you can use this link:

https://across.to/?from=1&to=42161&asset=eth&amount=100

I'll loop in @nicholaspai and @Tulun to verify that there are no outstanding issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants