Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

add: waitForDomain func to wait for a domain to be resolvable before pinging lets-encrypt #2236

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iwilltry42
Copy link
Contributor

Tiny helper function so we don't bother LE with unnecessary requests, just because the domain hasn't been propagated yet.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@iwilltry42 iwilltry42 marked this pull request as draft October 11, 2023 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant