Hack Theme Formatting and Repo setup #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nishantbalaji
commented
Aug 1, 2023
•
nishantbalaji
commented
- Added Hack coloring + styles to site, and redirecting theme links to ACM links
- Added CODEOWNERS file with ACM Hack team as owner
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nishantbalaji
requested review from
a team and
AVERGNET
and removed request for
a team
nishantbalaji
changed the title
alexzhang1618
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Everything looks good!
Some comments here I think we should address, but after that looks good to merge:
- The logo font is kinda small/hard to read, do we have a hack logo where the font is larger?
- I think the hack logo for the Discord server looks better for example
Regarding the logo, lets make a new PR for it. I couldn't find the svg so its not updated here |
silly goose u gotta hit approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.