Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Page #30

Merged
merged 6 commits into from
Sep 25, 2023
Merged

React Page #30

merged 6 commits into from
Sep 25, 2023

Conversation

AVERGNET
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 6:00am

nik-dange
nik-dange reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@nik-dange nik-dange left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a closer look a bit later, but from initial observations, is this breaking on your side too?
Screenshot 2023-09-17 at 10 04 24 PM

EDIT nvm this was fixed there was a small typo

nik-dange
nik-dange requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty solid! Just a few comments from me

pages/hack-school/react.mdx Outdated Show resolved Hide resolved
pages/hack-school/react.mdx Outdated Show resolved Hide resolved
pages/hack-school/react.mdx Show resolved Hide resolved
pages/hack-school/react.mdx Outdated Show resolved Hide resolved
pages/hack-school/react.mdx Outdated Show resolved Hide resolved
@nik-dange nik-dange linked an issue Sep 19, 2023 that may be closed by this pull request
React Page (Week 3) #12
Closed
angela139
angela139 requested changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I really like the content and examples! I left some suggestions and pointed out some typos.

pages/hack-school/react.mdx Show resolved Hide resolved
pages/hack-school/react.mdx Outdated Show resolved Hide resolved
pages/hack-school/react.mdx Show resolved Hide resolved
pages/hack-school/react.mdx Outdated Show resolved Hide resolved
pages/hack-school/react.mdx Show resolved Hide resolved
nik-dange
nik-dange approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@AVERGNET AVERGNET merged commit 3fd4854 into main Sep 25, 2023
3 checks passed
@AVERGNET AVERGNET deleted the nikhil-alexis/react branch September 25, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela139 angela139 angela139 approved these changes

@nik-dange nik-dange nik-dange approved these changes

@nishantbalaji nishantbalaji Awaiting requested review from nishantbalaji

@alexzhang1618 alexzhang1618 Awaiting requested review from alexzhang1618 alexzhang1618 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React Page (Week 3)
4 participants
@AVERGNET @nik-dange @angela139 @avVergnet