Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack School Introduction & Logistics Page #3

Merged
merged 11 commits into from
Aug 8, 2023
Merged

Hack School Introduction & Logistics Page #3

merged 11 commits into from
Aug 8, 2023

Conversation

nik-dange
Copy link
Member

Introductory pages (still need to fill it with specific links closer to the start of the school year).

@vercel
Copy link

vercel bot commented Jul 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview ✅ 2 resolved Aug 8, 2023 1:07am
nextra-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 1:07am

@nik-dange nik-dange requested a review from a team July 31, 2023 06:50
alexzhang1618
alexzhang1618 approved these changes Jul 31, 2023
View reviewed changes
pages/hack/other/test.mdx Outdated Show resolved Hide resolved
@nik-dange nik-dange changed the title Nikhil/introduction page Hack School Introduction & Logistics Page Aug 1, 2023
@nishantbalaji nishantbalaji requested review from a team and angela139 and removed request for a team August 1, 2023 17:03
alexzhang1618
alexzhang1618 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! For consistency, I think the folder Hack-School should be lowercase hack-school

alexzhang1618
alexzhang1618 reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments on Vercel:

  1. we can remove the Another page
  2. You can configure in meta.json so the sidebar appears as something other than Hack-School

khushijpatel
khushijpatel approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@khushijpatel khushijpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nik-dange nik-dange merged commit 3546432 into main Aug 8, 2023
3 checks passed
@nik-dange nik-dange deleted the nikhil/introduction-page branch August 8, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzhang1618 alexzhang1618 alexzhang1618 approved these changes

@khushijpatel khushijpatel khushijpatel approved these changes

@angela139 angela139 Awaiting requested review from angela139 angela139 is a code owner automatically assigned from acmucsd/acm-hack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik-dange @alexzhang1618 @khushijpatel