Homepage about section #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-dange
requested review from
nishantbalaji,
alexzhang1618 and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nik-dange
added
the
hold off on merge
nik-dange
removed
the
hold off on merge
angela139
requested changes
Sep 24, 2023
…ikhil/about-section
…ikhil/about-section merging main
AVERGNET
approved these changes
Sep 29, 2023
angela139
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
LGTM! I agree with Alexis about making the links more apparent tho. We can probably do a comprehensive review on the styling later on though. I think font sizing for the headers are a little different and there's still a border bottom on the about section. You can remove it for now.
|
hi I just saw this, jaw has dropped, looks great :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Holding off on merging until main homepage PR is merged.
How do i make the images look nice 😭 bruh