Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oxford asl 6 : fix_bolus should be a flag or dropdown rather than string param #211

Open
MontrealSergiy opened this issue Jul 26, 2021 · 0 comments
Labels

Comments

@MontrealSergiy
Copy link
Contributor

MontrealSergiy commented Jul 26, 2021

presently oxford asl fix_bolus parameter is string, yet there is no need for it. One either fixes bolus or allow for variable bolus. The label should be also 'Fix bolus duration', 'Bolus duration' label is already used for --bolus parameter.

see the source of oxford_asl

# fix the bolus duration?
if [ -z $fixbolus ]; then
    basil_options=$basil_options"--infertau "
    echo "Varaiable bolus duration" >> $log
else
    echo "Fixed bolus duration" >> $log
fi
@MontrealSergiy MontrealSergiy changed the title oxford asl 6 : fix_bolus should be boolean flag rather than numberic param oxford asl 6 : fix_bolus should be a flag rather than numeric param Jul 27, 2021
@MontrealSergiy MontrealSergiy changed the title oxford asl 6 : fix_bolus should be a flag rather than numeric param oxford asl 6 : fix_bolus should be a flag or dropdown rather than string param Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant