Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HookManager is fairly useless #1

Open
3 tasks
molenzwiebel opened this issue Nov 10, 2016 · 0 comments
Open
3 tasks

HookManager is fairly useless #1

molenzwiebel opened this issue Nov 10, 2016 · 0 comments
Labels
enhancement internals

Comments

@molenzwiebel
Copy link
Member

Currently, HookManager serves as a fairly useless collection of hooks. The hook function does some basic analysis of duplicate hooking, but ideally I would like it to be a lot more useful. For that, at least the following things need to happen:

  • Fix the equality check in areParamsEqual.
  • Figure out if we want to disallow duplicate hooks, or if we just want to warn about them.
  • Find a better way to relay the warnings to the developer/user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molenzwiebel