Move the BasePipeline class to a new aboutcode.pipeline module #1351
#1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
|
@tdruez can we also have |
Yes, this will happen in part 2 #1332 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1332 is already too complex combining the module refactoring, the Pipeline classes refactoring, packaging logic, and new CI for release publishing.
Let's split this into manageable and simpler-to-review parts.
The only goal of this PR is to move the current
BasePipelineclass to a newaboutcode.pipelinemodule without any code logic changes.The new module is free from
scanpipeordjangodependencies.