-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve copyrights detection #3752
Conversation
Reported-by: Anton Augsburg @vw-anton Reference: #3655 Signed-off-by: Philippe Ombredanne <[email protected]>
Reported-by: Dimitris Iliou @dimitris-iliou Reference: #3735 Signed-off-by: Philippe Ombredanne <[email protected]>
Spotted in some common python libraries such as numpy and scipy Signed-off-by: Philippe Ombredanne <[email protected]>
Use an input file where each line is either: - a URL to fetch - a text to test Then generate a test data files pair accordingly Signed-off-by: Philippe Ombredanne <[email protected]>
- Start detecting "is held by" - Do not include some trailing junk Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #3764 Reported-by: Anton Augsburg @vw-anton Signed-off-by: Philippe Ombredanne <[email protected]>
Make detection of copyright with a single lowercase name more specific Reference: #3764 Reported-by: Anton Augsburg @vw-anton Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This makes copyright detection more specific Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Also improve NOTICEs, and other misc. variants Don not detect "The Initial Developer" Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #3797 Reported-by: Jörg Arndt @Joerki Signed-off-by: Philippe Ombredanne <[email protected]>
Handle corner cases with markup Detect new copyright forms. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
* Handle better various parens, markup and quotes Signed-off-by: Philippe Ombredanne <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pombredanne we need to fix the test failures here and after regenerating it seems to me like some of these are regressions potentially, we need more review of these failures.
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
@AyanSinhaMahapatra ready for your review, all greeen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I have a couple small questions and fixes here.
Signed-off-by: Philippe Ombredanne <[email protected]> Co-authored-by: Ayan Sinha Mahapatra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks++ @pombredanne This improves copyright detection a lot!
Merging!
This PR improves copyright detection
Tasks
Run tests locally to check for errors.