Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright detection error when scanning cxxtest.spec from cxxtest-3.10.1.tar.gz #1248

Closed
JonoYang opened this issue Nov 3, 2018 · 2 comments
Assignees
Milestone

Comments

@JonoYang
Copy link
Member

JonoYang commented Nov 3, 2018

ScanCode returns Copyright LGPL Group when scanning cxxtest.spec. Below is the content of cxxtest.spec:

Name: cxxtest
Summary: CxxTest Testing Framework for C++
Version: 3.10.1
Release: 1
Copyright: LGPL
Group: Development/C++
Source: cxxtest-%{version}.tar.gz
BuildRoot: /tmp/cxxtest-build
BuildArch: noarch
Prefix: /usr

%description
CxxTest is a JUnit/CppUnit/xUnit-like framework for C++.
Its advantages over existing alternatives are that it:
 - Doesn't require RTTI
 - Doesn't require member template functions
 - Doesn't require exception handling
 - Doesn't require any external libraries (including memory management, 
   file/console I/O, graphics libraries)

%prep
%setup -n cxxtest

%build

%install
install -m 755 -d $RPM_BUILD_ROOT/usr/bin $RPM_BUILD_ROOT/usr/include/cxxtest
install -m 755 cxxtestgen.p[ly] $RPM_BUILD_ROOT/usr/bin/
install -m 644 cxxtest/* $RPM_BUILD_ROOT/usr/include/cxxtest/

%clean
rm -rf $RPM_BUILD_ROOT

%files
%attr(-, root, root) %doc README
%attr(-, root, root) %doc sample
%attr(-, root, root) /usr/include/cxxtest
%attr(-, root, root) /usr/bin/cxxtestgen.pl
%attr(-, root, root) /usr/bin/cxxtestgen.py
@pombredanne pombredanne self-assigned this Nov 3, 2018
pombredanne added a commit that referenced this issue Nov 3, 2018
Also added a few license detection rules specifically for cxxtest

Reported-by: @JonoYang
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne
Copy link
Member

I reported a ticket at CxxTest/cxxtest#142 since the LGPL tag they use in the spec file is ambiguous

pombredanne added a commit that referenced this issue Nov 4, 2018
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne added a commit that referenced this issue Nov 4, 2018
There were tests for copyrights that use LGPL. So making this a JUNK
token does not work

Reported-by: @JonoYang
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne pombredanne added this to the v3.0 milestone Nov 5, 2018
@pombredanne
Copy link
Member

Thank you for the report: this is fixed and merged in develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants