Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplying nnbench.Transforms directly to record IO #131

Open
nicholasjng opened this issue Mar 26, 2024 · 0 comments
Open

Supplying nnbench.Transforms directly to record IO #131

nicholasjng opened this issue Mar 26, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request refactor Makes existing code nicer and more useable.

Comments

@nicholasjng
Copy link
Collaborator

TL,DR: I would like to replace this pattern:

record = runner.run(__name__, params={...})
transform = MyTransform()
trecord = transform.apply(record)
FileIO.write(trecord)

with this:

record = runner.run(__name__, params={...})
FileIO.write(record, *, transform=MyTransform())

Meaning that a single transform can be given and applied to a record in a write() / read(), similarly in other IO types we have.

@nicholasjng nicholasjng added enhancement New feature or request refactor Makes existing code nicer and more useable. labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Makes existing code nicer and more useable.
Projects
None yet
Development

No branches or pull requests

1 participant