Replace some Option<u8> to Option<NonZeroU8> #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1ien
force-pushed
the
option_none_zero_u8
branch
from
6b15215
to
be02e4f
Compare
manufacturer_string_index serial_number_string_index product_string_index description_string_index ref #88
a1ien
force-pushed
the
option_none_zero_u8
branch
from
be02e4f
to
7c952ba
Compare
|
Yes, I think so. It models the underlying concepts better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you think this looks better? @raphaelcohn
Close #88