Nginx configuration fixes for large libraries #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 5. - [Release notes](https://github.com/docker/metadata-action/releases) - [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md) - [Commits](docker/metadata-action@v4...v5) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…er/metadata-action-5 build(deps): bump docker/metadata-action from 4 to 5
fix(save_manager): traverse remote folders with recursion
fix(save_manager): do not close the connection if the file is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems Tinfoil app parses only a small part of index (GET /) and if library is fairly large (and directories listing comes before the files listing) then it cannot find /shop.tfl and does not recognize shop at Tinfoil app start.
Additionally it has correct supervisor script. See docker documentation https://docs.docker.com/config/containers/multi-service_container/
And small chore in part of optimization of docker build speed (order of commands + cleaned up docker context).
Docker image for checking out the fixes: https://hub.docker.com/r/postpersonality/ownfoil