Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we determine use which ModSqrt #1

Open
zyfrank opened this issue Jun 17, 2019 · 1 comment
Open

Should we determine use which ModSqrt #1

zyfrank opened this issue Jun 17, 2019 · 1 comment

Comments

@zyfrank
Copy link

zyfrank commented Jun 17, 2019

x = FQ(square_root_mod_prime(int(xsq), JUBJUB_Q))

As we know, an element of Fp may have several ModSqrt, for example 4 of F5 has two: 2, 3. should we determine use which ModSqrt? otherwise this will lead to conflict with other implementation(because they can choose another ModSqrt)

@zyfrank
Copy link
Author

zyfrank commented Jun 17, 2019

What I mean is that ModSqrt can have two roots (or none), maybe we should define use the smaller or bigger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant