Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from address of Eth transactions #705

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

yaron-zilliqa
Copy link
Contributor

@yaron-zilliqa yaron-zilliqa commented Jun 3, 2024

No description provided.

@yaron-zilliqa yaron-zilliqa linked an issue Jun 3, 2024 that may be closed by this pull request
@yaron-zilliqa yaron-zilliqa force-pushed the 704-fix-from-address-of-eth-transactions-in-devex branch 4 times, most recently from 90a1417 to cd724dd Compare June 3, 2024 19:00
@yaron-zilliqa yaron-zilliqa changed the title Add ethers v5.7 and return the correct sender address if the transaction Fix from address of Eth transactions Jun 3, 2024
rrw-zilliqa
rrw-zilliqa previously approved these changes Jun 18, 2024
Copy link
Contributor

@rrw-zilliqa rrw-zilliqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

@yaron-zilliqa yaron-zilliqa force-pushed the 704-fix-from-address-of-eth-transactions-in-devex branch 3 times, most recently from 28609c5 to 4af94c6 Compare June 18, 2024 13:12
Copy link
Contributor

@rrw-zilliqa rrw-zilliqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

@yaron-zilliqa yaron-zilliqa merged commit d77f63f into main Jun 18, 2024
14 of 15 checks passed
@yaron-zilliqa yaron-zilliqa deleted the 704-fix-from-address-of-eth-transactions-in-devex branch June 18, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix from address of Eth transactions in devex
2 participants