-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVOPS-903: devex-apollo gcp migration #170
Conversation
pavlops
commented
Aug 14, 2023
•
edited
Loading
edited
- removed staging functionality from old pipeline.
- added devex-apollo to gcp pipeline.
- kustomize files adapted to new schemes.
To note: @JamesHinshelwood The lint is marking me to change this line: products/devex-apollo/index.js:151:41 However if I change it, I get this runtime issue:
If I keep the original line (https://github.com/Zilliqa/Devex-apollo/blob/master/index.js#L138) the application works fine. And this is how it was working from before: We can keep it like this but the Lint will fail. Any suggestion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)