Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use media queries for dark theme #7

Open
NightScript370 opened this issue May 9, 2023 · 2 comments
Open

Use media queries for dark theme #7

NightScript370 opened this issue May 9, 2023 · 2 comments

Comments

@NightScript370
Copy link
Member

The browser already does the heavy lifting for us. It is rather pointless to implement it ourselves
@NightScript370
Copy link
Member Author

This is implemented
Should we implement an override for browsers that do not implement the proper media queries?

@Elyahu41
Copy link
Collaborator

Ideally, yes. We want to support as many browsers as possible. Also, it is recommended practice to mention the commit that fixed the issue in the discussion, as github will automatically detect it. Like so: issue #11 and the commit 1e7cc16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NightScript370 @Elyahu41