Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Mode - Shabbat Mode replacement #12

Open
NightScript370 opened this issue May 22, 2023 · 0 comments
Open

Auto Mode - Shabbat Mode replacement #12

NightScript370 opened this issue May 22, 2023 · 0 comments

Comments

@NightScript370
Copy link
Member

NightScript370 commented May 22, 2023

The current implementation of Shabbat Mode mirrorly increments the screens y position by about 3 px every absolute 50mil, which makes for a non-smooth scrolling. The indicator that this isn't a bug but rather a feature is with an absolute positioned banner on the top that reads Shabbat mode as long as the 5 times the text is defined wouldn't disappear if your screen is too wide because a 6th element wasn't added. To disable this, you first need to click on the banner to disable it, then get the screen to scroll to the nav bar and finally disable it from there...
...needless to say, this did not take into account the recent advancements we made for desktop users. With all the horizontal width we take advantage of, there is no scrolling that could happen on a 1440p screen. As such, only the fact that there is a blue bar is the indicator.

To fix this, I would like to rename Shabbat Mode to "Auto Mode", which would be inclusive of Yom Tov and convey the purpose in the name. With that, there would actually be three implementations:

  • Off: Must I explain?
  • Category flipper: Wed put each time into different categories which wed then flip through every few seconds.
  • Burn in-Reduction: Current system, except using requestAnimationFrames and a modal for canceling when touching anywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant