Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect pdist_scale and gdist_scale for fetch_navigation in local planner #99

Open
NorwegianRockCat opened this issue Nov 22, 2018 · 0 comments

Comments

@NorwegianRockCat
Copy link

Hello,

I've been playing around with the local planner and Fetch. I based my code off the base_local_planner and was copying the configuration variables over, when I saw this in fetch_navigation/config/move_base.yaml

pdist_scale: 8.0
gdist_scale: 12.0

However, if you look at the (documentation of these parameters)[https://wiki.ros.org/base_local_planner#Trajectory_Scoring_Parameters]. It says that the maximum value is 5.0 for both of them. I checked and indeed, both of these values are restricted to 5.0 when the local_planner plugin is loaded. This means that both path and goal are weighted the same.

Maybe this is a happy accident, but if that is the case, perhaps these values should both be set at 5.0. Otherwise, if there really is a desire to have a 2/3 ratio between pdist_scale and gdist_scale, it might make more sense to have the values be something like (2 and 3)?

I can happily submit a pull request with corrected values, but I suspect others know the robot much better than I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant