Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the zebra_scan crate to work with the last ECC dependencies #8809

Closed
oxarbitrage opened this issue Aug 27, 2024 · 1 comment · Fixed by #8918
Closed

Fix the zebra_scan crate to work with the last ECC dependencies #8809

oxarbitrage opened this issue Aug 27, 2024 · 1 comment · Fixed by #8918
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-dependencies Area: Dependency file updates P-Low ❄️

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Aug 27, 2024

In #8810 we upgraded the ECC dependencies to the last version, for Nu6. However, we had to make an exception for the zebra-scan crate due to the following building error:

error[E0308]: `?` operator has incompatible types
   --> zebra-scan/src/service/scan_task/scan.rs:552:35
    |
552 |       UnifiedFullViewingKey::parse(&Ufvk::try_from_items(vec![Fvk::try_from((
    |  ___________________________________^
553 | |         2,
554 | |         &dfvk.to_bytes()[..],
555 | |     ))?])?)
    | |__________^ expected `zcash_address::kind::unified::fvk::Ufvk`, found `Ufvk`
    |
    = note: `?` operator cannot convert from `Ufvk` to `zcash_address::kind::unified::fvk::Ufvk`
    = note: `Ufvk` and `zcash_address::kind::unified::fvk::Ufvk` have similar names, but are actually distinct types
note: `Ufvk` is defined in crate `zcash_address`
   --> /home/alfredo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zcash_address-0.5.0/src/kind/unified/fvk.rs:106:1
    |
106 | pub struct Ufvk(pub(crate) Vec<Fvk>);
    | ^^^^^^^^^^^^^^^
note: `zcash_address::kind::unified::fvk::Ufvk` is defined in crate `zcash_address`
   --> /home/alfredo/.cargo/git/checkouts/librustzcash-0a74bd38a00f78b0/a1047ad/components/zcash_address/src/kind/unified/fvk.rs:106:1
    |
106 | pub struct Ufvk(pub(crate) Vec<Fvk>);
    | ^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `zcash_address` are being used?
@oxarbitrage oxarbitrage added A-dependencies Area: Dependency file updates A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Low ❄️ labels Aug 27, 2024
@oxarbitrage
Copy link
Contributor Author

oxarbitrage commented Aug 28, 2024

Additionally, when we fix this, make sure the last 3 warnings are gone:

#18 0.201 warning: /zebra-utils/Cargo.toml: version requirement `0.9.34+deprecated` for dependency `serde_yaml` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion
#18 0.201 warning: /zebra-scan/Cargo.toml: unused manifest key: dependencies.zcash_address.commit
#18 0.201 warning: /zebra-scan/Cargo.toml: unused manifest key: dependencies.zcash_client_backend.commit
#18 0.201 warning: /zebra-scan/Cargo.toml: unused manifest key: dependencies.zcash_primitives.commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-dependencies Area: Dependency file updates P-Low ❄️
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant