From 568f206e2b6f2b0eb55b4ed22c4317b93130a1f7 Mon Sep 17 00:00:00 2001 From: Ziggy Jonsson Date: Sun, 14 Apr 2024 09:35:41 -0400 Subject: [PATCH] Add github actions --- .circleci/config.yml | 13 --------- .github/workflows/coverage.yml | 50 ++++++++++++++++++++++++++++++++++ .github/workflows/test.yml | 26 ++++++++++++++++++ package.json | 2 +- test/extractFromUrl.js | 27 +++++++++--------- 5 files changed, 90 insertions(+), 28 deletions(-) delete mode 100644 .circleci/config.yml create mode 100644 .github/workflows/coverage.yml create mode 100644 .github/workflows/test.yml diff --git a/.circleci/config.yml b/.circleci/config.yml deleted file mode 100644 index 62a1f0b..0000000 --- a/.circleci/config.yml +++ /dev/null @@ -1,13 +0,0 @@ -version: 2 -jobs: - build: - docker: - - image: circleci/node:10.15 - working_directory: ~/build - steps: - - checkout - - run: npm install - - run: npm t - - store_artifacts: - path: coverage/lcov-report - destination: coverage diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml new file mode 100644 index 0000000..87566d8 --- /dev/null +++ b/.github/workflows/coverage.yml @@ -0,0 +1,50 @@ +name: Deploy coverate report to Pages + +on: + # Runs on pushes targeting the default branch + push: + branches: ["master"] + + # Allows you to run this workflow manually from the Actions tab + workflow_dispatch: + +# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages +permissions: + contents: read + pages: write + id-token: write + +# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued. +# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete. +concurrency: + group: "pages" + cancel-in-progress: false + +jobs: + # Single deploy job since we're just deploying + coverage: + environment: + name: github-pages + url: ${{ steps.deployment.outputs.page_url }} + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + - name: Use Node.js 18 + uses: actions/setup-node@v3 + with: + node-version: '18.x' + - run: npm install + - run: npm run build --if-present + - run: npm test + - run: npx lcov-badge2 coverage/lcov.info -o coverage/lcov-report/badge.svg + - name: Setup Pages + uses: actions/configure-pages@v3 + - name: Upload artifact + uses: actions/upload-pages-artifact@v2 + with: + path: 'coverage/lcov-report' + - name: Deploy to GitHub Pages + id: deployment + uses: actions/deploy-pages@v2 + \ No newline at end of file diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml new file mode 100644 index 0000000..26100ba --- /dev/null +++ b/.github/workflows/test.yml @@ -0,0 +1,26 @@ +name: Node.js CI + +on: + push: + branches: [ master ] + pull_request: + branches: [ master ] + workflow_dispatch: + +jobs: + test: + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [18.x, 20.x] + + steps: + - uses: actions/checkout@v3 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node-version }} + - run: npm install + - run: npm run build --if-present + - run: npm test \ No newline at end of file diff --git a/package.json b/package.json index 9f2dffc..e44d6d7 100644 --- a/package.json +++ b/package.json @@ -40,7 +40,7 @@ "iconv-lite": "^0.4.24", "request": "^2.88.0", "stream-buffers": ">= 0.2.5 < 1", - "tap": ">= 0.3.0 < 1", + "tap": "^18.7.2", "temp": ">= 0.4.0 < 1" }, "directories": { diff --git a/test/extractFromUrl.js b/test/extractFromUrl.js index 0bafb09..18b0451 100644 --- a/test/extractFromUrl.js +++ b/test/extractFromUrl.js @@ -6,22 +6,21 @@ var unzip = require("../"); var os = require("os"); var request = require("request"); -test("extract zip from url", function (t) { +test("extract zip from url", async t => { + t.setTimeout(15000); var extractPath = os.tmpdir() + "/node-unzip-extract-fromURL"; // Not using path resolve, cause it should be resolved in extract() function - unzip.Open.url( + const zip = await unzip.Open.url( request, "https://github.com/h5bp/html5-boilerplate/releases/download/v7.3.0/html5-boilerplate_v7.3.0.zip" - ) - .then(function(d) { return d.extract({ path: extractPath }); }) - .then(function(d) { - var dirFiles = fs.readdirSync(extractPath); - var isPassing = - dirFiles.length > 10 && - dirFiles.indexOf("css") > -1 && - dirFiles.indexOf("index.html") > -1 && - dirFiles.indexOf("favicon.ico") > -1; + ); + await zip.extract({ path: extractPath }); + + var dirFiles = fs.readdirSync(extractPath); + var isPassing = + dirFiles.length > 10 && + dirFiles.indexOf("css") > -1 && + dirFiles.indexOf("index.html") > -1 && + dirFiles.indexOf("favicon.ico") > -1; - t.equal(isPassing, true); - t.end(); - }); + t.equal(isPassing, true); });