New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the CLA of GET_RESPONSE(0xC0) command still be 0x00 for ctap2 case? #816

Closed

nuno0529 opened this issue Aug 26, 2024 · 2 comments

Assignees

Labels

bug report

nuno0529 commented Aug 26, 2024

libfido2 code here force use 0x00, https://github.com/Yubico/libfido2/blob/main/src/nfc.c#L187

ctap2 spec examples use 0x80, https://fidoalliance.org/specs/fido-v2.2-rd-20230321/fido-client-to-authenticator-protocol-v2.2-rd-20230321.html#nfc-fragmentation
u2f spec examples use 0x00, https://fidoalliance.org/specs/fido-u2f-v1.2-ps-20170411/fido-u2f-nfc-protocol-v1.2-ps-20170411.html#apdu-length

As ISO7816-4, the CLA of GET_RESPONSE(0xC0) command is not fixed to 0x00, https://cardwerk.com/smart-card-standard-iso7816-4-section-7-transmission-interindustry-commands/

nuno0529 added the bug report label

Member

kongeo commented Aug 26, 2024

Hi @nuno0529,
thanks for bringing this up. Yes I think that makes sense. We will merge a fix as soon as possible.

kongeo self-assigned this

Member

kongeo commented Sep 12, 2024

addressed in #817

kongeo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment