Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making more checks before reading input packets #14

Open
Youx opened this issue Oct 17, 2009 · 0 comments
Open

Making more checks before reading input packets #14

Youx opened this issue Oct 17, 2009 · 0 comments

Comments

@Youx
Copy link
Owner

Youx commented Oct 17, 2009

There are mainly 2 kinds of security issues :

  • check the input size is correct before reading anything from the input packet
  • when we read an null-terminated string (\0 terminated) at the end of a packet, we should use strndup(ptr, data + input_len - ptr) so that we cannot try to read beyond the packet end if the string is NOT null terminated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant