Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

271 add problem and notification components to alert center #21646

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

271 add problem and notification components to alert center #21646

wants to merge 6 commits into from
+209 −7

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Sep 19, 2024 •
edited
Loading

Context

  • We want to add only the UI components for the problems and notifications center.

Summary

This PR can be summarized in the following changelog entry:

  • Adds problems and notifications sections in alert center.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to Yoast SEO -> New Dashboard
  • Check the notification and problems section match the design
  • Check also the hidden alerts are matching the design.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Add problem card to Alert center

@vraja-pro vraja-pro added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Sep 19, 2024
@vraja-pro vraja-pro changed the title 271 add problem card to alert center 271 add problem and notification components to alert center Sep 19, 2024
@coveralls
Copy link

coveralls commented Sep 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 4c4036b4ce2081d5306511f5ce177f812fcfc06b

Details

  • 0 of 23 (0.0%) changed or added relevant lines in 6 files are covered.
  • 4289 unchanged lines in 145 files lost coverage.
  • Overall coverage decreased (-5.2%) to 49.349%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/dashboard/routes/alert-center.js 0 1 0.0%
packages/js/src/dashboard/components/alert-title.js 0 4 0.0%
packages/js/src/dashboard/components/collapsible.js 0 4 0.0%
packages/js/src/dashboard/components/notifications.js 0 4 0.0%
packages/js/src/dashboard/components/problems.js 0 4 0.0%
packages/js/src/dashboard/components/alerts-list.js 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
admin/class-option-tabs-formatter.php 1 0.0%
packages/js/src/dashboard/components/notifications.js 1 0.0%
packages/js/src/dashboard/components/problems.js 1 0.0%
src/actions/configuration/first-time-configuration-action.php 1 91.84%
src/builders/indexable-home-page-builder.php 1 98.0%
src/builders/indexable-term-builder.php 1 99.15%
src/context/meta-tags-context.php 1 28.29%
src/editors/framework/site/post-site-information.php 1 93.88%
src/generators/breadcrumbs-generator.php 1 64.23%
src/generators/schema/webpage.php 1 90.32%
Totals Coverage Status
Change from base Build 6e5689ecd840a41428c113b246f26484fa556426: -5.2%
Covered Lines: 25524
Relevant Lines: 53440
💛 - Coveralls

igorschoester
igorschoester requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial CR 😅

packages/js/src/dashboard/components/list.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/list.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/hidden-alerts-collapsible.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/box-title.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/list.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/hidden-alerts-collapsible.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/list.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/box-title.js Outdated Show resolved Hide resolved
@vraja-pro vraja-pro force-pushed the 271-add-problem-card-to-alert-center branch 3 times, most recently from 3ed3932 to 290dfac Compare September 19, 2024 09:51
igorschoester
igorschoester requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial CR 😅

packages/js/src/dashboard/routes/alert-center.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/problems.js Show resolved Hide resolved
packages/js/src/dashboard/components/alert-title.js Outdated
return (
<div className="yst-flex yst-justify-between yst-gap-2 yst-items-center">
<Icon className={ classNames( "yst-w-6 yst-h-6", iconClass ) } />
<Title className="yst-grow" as="h3" size="2">{ title } { counts > 0 && `(${counts})` }</Title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why h3? It seems to me this is semantic level 2 after the Alert center' h1
  • Why no count when it is 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it says in the design h3, about the counts, I'll ask @ux-tom

packages/js/src/dashboard/components/alert-title.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/alerts-list.js Show resolved Hide resolved
packages/js/src/dashboard/components/collapsible.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/collapsible.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/collapsible.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/alerts-list.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/alerts-list.js Outdated Show resolved Hide resolved
igorschoester
igorschoester requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more AT remarks!

packages/js/src/dashboard/components/problems.js Show resolved Hide resolved
packages/js/src/dashboard/components/collapsible.js Outdated Show resolved Hide resolved
packages/js/src/dashboard/components/collapsible.js Show resolved Hide resolved
@vraja-pro
feat: fix styling
476ff2e 
refactor comment

clear property

feat: deconstruct context

feat: restore styling

feat: add safety check for deconstructing the context

fix padding in collapsible

fix js doc comment

fix margin

fix collapsable
@vraja-pro vraja-pro force-pushed the 271-add-problem-card-to-alert-center branch from 290dfac to 476ff2e Compare September 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorschoester igorschoester igorschoester requested changes

Assignees
No one assigned
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vraja-pro @coveralls @igorschoester