Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/decouple hidden fields #21412

Open
wants to merge 367 commits into
base: trunk
Choose a base branch
from
Open

Conversation

vraja-pro
Copy link
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Decouple metabox from hidden fields.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

… hidden and we need to register the metadata.
I changed the listener to listen to the actual change like in the classic editor.
in inc/options/class-wpseo-option-social.php lines 39 and 42
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 28, 2024
@coveralls
Copy link

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 63f1c2048ebf6739a8e1f47501ce487325853f3d

Details

  • 35 of 228 (15.35%) changed or added relevant lines in 40 files are covered.
  • 4347 unchanged lines in 125 files lost coverage.
  • Overall coverage decreased (-4.2%) to 48.383%

Changes Missing Coverage Covered Lines Changed/Added Lines %
admin/taxonomy/class-taxonomy-fields-presenter.php 0 1 0.0%
packages/js/src/elementor.js 0 1 0.0%
packages/js/src/elementor/containers/SnippetEditor.js 0 1 0.0%
packages/js/src/redux/initial-state/analysis.js 0 1 0.0%
packages/js/src/redux/initial-state/index.js 0 1 0.0%
packages/js/src/redux/initial-state/schemaTab.js 0 1 0.0%
src/presenters/admin/meta-fields-presenter.php 0 1 0.0%
admin/class-primary-term-admin.php 0 2 0.0%
admin/metabox/class-metabox.php 0 2 0.0%
packages/js/src/initializers/block-editor-integration.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
admin/class-option-tabs-formatter.php 1 0.0%
packages/js/src/analysis/TermDataCollector.js 1 37.5%
packages/js/src/components/SchemaTab.js 1 0.0%
packages/js/src/containers/AdvancedSettings.js 1 0.0%
packages/js/src/containers/FacebookEditor.js 1 0.0%
packages/js/src/containers/SchemaTab.js 1 0.0%
packages/js/src/containers/TwitterEditor.js 1 0.0%
packages/js/src/elementor/containers/ElementorFill.js 1 0.0%
packages/js/src/elementor/containers/FacebookEditor.js 1 0.0%
packages/js/src/elementor/containers/SnippetEditor.js 1 0.0%
Totals Coverage Status
Change from base Build 1cf35a642214d42d952dcb13a93482167c3c9f59: -4.2%
Covered Lines: 24963
Relevant Lines: 53453

💛 - Coveralls

vraja-pro and others added 2 commits May 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants