Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower privilege for setup #99

Open
wants to merge 1 commit into
base: 11.0
Choose a base branch
from
Open

Lower privilege for setup #99

wants to merge 1 commit into from

Conversation

tresf
Copy link

@tresf tresf commented May 2, 2018

  • sudo isn't need for wget
  • sh prevents needing chmod
  • odoo_install.sh asks for credentials naturally

* `sudo` isn't need for `wget`
* `sh` prevents needing `chmod`
* `odoo_install.sh` asks for credentials naturally
@Yenthe666
Copy link
Owner

@tresf,

Thanks for the PR / ideas.
For the sudo: this is because some people try to do this in a folder where they have not enough rights, sudo will always 'win' in this case.
For the second part, I never tried the differences so I'll try it as soon as possible to check. thanks!

@Yenthe666 Yenthe666 self-requested a review May 2, 2018 07:02
@tresf
Copy link
Author

tresf commented May 2, 2018

For the sudo: this is because some people try to do this in a folder where they have not enough rights, sudo will always 'win' in this case.

No they don't. Please don't spread this stuff around, it's simply incorrect. A terminal defaults to ~, moving forward you should always write your scripts to honor that. Never run something as sudo that doesn't need root access to the system. All this does is create a file that can't be easily deleted in a user's home directory and that's wrong. 😃

For the second part, I never tried the differences so I'll try it as soon as possible to check. thanks!

For the record, the script fails on Ubuntu 14.04 and the others I've found on the internet seem to fail as well. It may be worth porting the repo to Circle-CI or Travis-CI or something to make sure it works. This process was quite involved so I ended up installing Odoo on Windows just to try it out (still struggling there as well, but that's another topic).

But please move away from sudo. It has no place in a wget call that places something in ~.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants