Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwaggerClient.from_url should have timeout #460

Open
guerda opened this issue May 15, 2020 · 2 comments
Open

SwaggerClient.from_url should have timeout #460

guerda opened this issue May 15, 2020 · 2 comments

Comments

@guerda
Copy link

guerda commented May 15, 2020

The requests in bravado can be configured to have a timeout. Unfortunately, this does not affect the from_url() method.
Would it be possible to add a time out feature in that method, too?

Best,
Philip

@guerda
Copy link
Author

guerda commented May 28, 2020

Maybe it's possible to insert the timeout into the request headers here:

loader = Loader(http_client, request_headers=request_headers)

@sjaensch
Copy link
Contributor

We'll need to pass a timeout argument to the result call. The best option is probably to add a timeout argument to SwaggerClient.from_url and pass it down the call chain. @guerda, would you be interested in working on a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants