Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more than 2 start values issues #30

Open
raziza opened this issue Jan 22, 2017 · 7 comments
Open

more than 2 start values issues #30

raziza opened this issue Jan 22, 2017 · 7 comments

Comments

@raziza
Copy link

raziza commented Jan 22, 2017

When having more than 2 values to our slider only first 2 are being synced.

Fix: 'equals' and createSlider methods should be changed to loop over the start values and not hard coded first and second items.

@Yankovsky
Copy link
Owner

Yankovsky commented Jan 23, 2017

Actually, I didn't know that nouislider supports more than 2 handles.

@Yankovsky
Copy link
Owner

Ok, it was added in 9.0.0 version and currently this lib supports ~8.5.1

@leongersen
Copy link

leongersen commented Jan 23, 2017

@Yankovsky While technically not b/w compatible (the DOM changes), upgrading to noUiSlider 9 should be hassle-free. There are no API changes.

@raziza
Copy link
Author

raziza commented Jan 23, 2017

Yeah, I've changed this part in your code and nothing else and looks like it is working fine (so far).

@kikitsa
Copy link

kikitsa commented Aug 29, 2017

Same problem here. As @raziza said you have to change the values in a loop in update function (line 78). In addition you have to write a new equals function (line 14), for example here

Are you planning for an updated release?

@Yankovsky
Copy link
Owner

@raziza as I understand you've solved this issue. Can you create pr?

@Yankovsky
Copy link
Owner

@kikitsa @leongersen Do you still need help with that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants