Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCLBinGen silently emits at most 5 bos in kernels.json even if @sequence has more #1564

Open
makslevental opened this issue Jun 14, 2024 · 3 comments
Assignees

Comments

@makslevental
Copy link
Contributor

makslevental commented Jun 14, 2024

https://github.com/Xilinx/mlir-aie/blob/main/test/aie2xclbin/buffers_xclbin.mlir#L115:

func.func @sequence(%arg0: memref<1024xi32>, %arg1: memref<1024xi32>, %arg2: memref<1024xi32>, %arg3: memref<1024xi32>, %arg4: memref<1024xi32>, %arg5: memref<1024xi32>)

ie 6 args but final bo in kernels.json

// CHECK:           {
// CHECK:             "address-qualifier": "GLOBAL",
// CHECK:             "memory-connection": "HOST",
// CHECK:             "name": "bo4",
// CHECK:             "offset": "0x34",
// CHECK:             "type": "void*"
// CHECK:           }

ie 5th arg.

cc @nirvedhmeshram

@fifield
Copy link
Collaborator

fifield commented Jun 14, 2024

I've reverted the related changes from #1517 in #1565 so that at least the test makes sense, but it does not solve the complaint in the issue title about no error.

@makslevental
Copy link
Contributor Author

makslevental commented Jun 15, 2024

does not solve the complaint in the issue title about no error.

So then why not solve it by checking how many args sequence expects...? Or in fact actually emitting the right number of bo entries in the json instead of hard coding some arbitrary quantity.

@fifield
Copy link
Collaborator

fifield commented Jun 15, 2024

does not solve the complaint in the issue title about no error.

So then why not solve it by checking how many args sequence expects...? Or in fact actually emitting the right number of bo entries in the json instead of hard coding some arbitrary quantity.

Yes that would be the right thing for someone to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants