Issues with xinterrupt_wrap

[aforster-mr]

I am trying to adopt this example to implement a custom interrupt handler. The example works but I found two issues when modifying it for my use case.

• According to the example, XINTR_IS_EDGE_TRIGGERED (defined as 3) should be passed as the TriggerType parameter to XGetEncodedIntrId to define an edge triggered interrupt. This is not one of the valid values given by the comment for XGetEncodedIntrId.
  

  embeddedsw/lib/bsp/standalone/src/common/intr/xinterrupt_wrap.h

  Line 61 in 5688620

  #define XINTR_IS_EDGE_TRIGGERED 3U

  
  

  embeddedsw/lib/bsp/standalone/src/common/intr/xinterrupt_wrap.c

  Lines 465 to 470 in 5688620

  	* @param : TriggerType Trigger type for targted interrupt ID (documented in
  	* TRM of targeted SoC)
  	* 1 = low-to-high edge triggered
  	* 2 = high-to-low edge triggered
  	* 4 = active high level-sensitive
  	* 8 = active low level-sensitive

  This causes problems down the line. For example in XSetPriorityTriggerType where the value is compared against 1 and 2. A level trigger is selected when we wanted an edge trigger.

  embeddedsw/lib/bsp/standalone/src/common/intr/xinterrupt_wrap.c

  Lines 304 to 309 in 5688620

  	void XSetPriorityTriggerType( u32 IntrId, u8 Priority, UINTPTR IntcParent)
  	{
  	#if defined (XPAR_SCUGIC)
  	u8 Trigger = (((XGet_TriggerType(IntrId) == 1) ||
  	(XGet_TriggerType(IntrId) == 2)) ? XINTR_IS_EDGE_TRIGGERED
  	: XINTR_IS_LEVEL_TRIGGERED);

• In the implementation of XGetEncodedIntrId, XINTC_INTR_TYPE_SHIFT is used directly as a bitmask when it should instead be used to shift a bit.
  

  embeddedsw/lib/bsp/standalone/src/common/intr/xinterrupt_wrap.c

  Lines 500 to 504 in 5688620

  	} else if (IntrType == XPPI) {
  	*IntrId -= 16;
  	*IntrId |= XINTC_INTR_TYPE_SHIFT;
  	} else if (IntrType == XSGI) {
  	*IntrId |= (1 << XINTC_IS_SGI_INTR_SHIFT);

• (also, there is a typo in the change data of the example file)
  

  embeddedsw/XilinxProcessorIPLib/drivers/scugic/examples/xscugic_example.c

  Line 39 in 5688620

  * 5.2 mus 04/33/34 Use interrupt wrapper APIs in case of SDT flow.