Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates PRs with no changes #171

Open
bittrance opened this issue Jan 25, 2022 · 0 comments
Open

Creates PRs with no changes #171

bittrance opened this issue Jan 25, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@bittrance
Copy link
Contributor

Even if a promotion updates zero image tags, a PR will still be created, which is somewhat confusing. You can merge this empty PR in QA and trigger creation of a promote PR for prod, effectively skipping a verification step. It is not clear to me what should be done in this case. The behavior is probably correct for the new command but less reasonable for promote. Or possibly the PR should just say "OMG, there are NO CHANGES!!!".
@bittrance bittrance added the enhancement New feature or request label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bittrance