Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration doesn't save #5

Open
KB8RCO opened this issue Mar 12, 2020 · 3 comments
Open

Configuration doesn't save #5

KB8RCO opened this issue Mar 12, 2020 · 3 comments

Comments

@KB8RCO
Copy link

KB8RCO commented Mar 12, 2020

I understand this is still preliminary, but the basic configuration (call, SSID, passcode, location) does not seem to save. It does keep the call and configuration for the interface.

Are updates planned, or has this been dropped?

@godfreja
Copy link
Contributor

I'm not aware of anyone actively working on it.

@tvrusso
Copy link
Member

tvrusso commented Mar 12, 2020

I don't believe any work has been done on this in almost a year, and then it was only to pull it out of the main Xastir project and into its own repo. As it barely does more than monitor packets, it's not that useful, and there hasn't been anyone tripping over themselves to add functionality.

Something is clearly amiss in the stationsettings.cpp functions that save configuration --- there are saved bits of configuration such as lat/lon and station symbol but they appear to be getting written out as @Variant data and are either not being written correctly or not being read back in correctly.
I find lat/lon being incorrect, and the station symbol being only half right (I have \X set and get only the X back on restart). The station with ssid is right, but nothing else. (the settings, by the way, are saved in "~/.config/Xastir Group/Xastir QT.conf" and you can see for yourself what's being incorrectly saved).

I find that all the interface configuration is correctly saved, though, including passcode and filter.

My config file winds up looking like:

[DeviceInterfaces]
Interface0\activateOnStartup=true
Interface0\allowTransmit=false
Interface0\callsign=KM5VY
Interface0\filter=r/35/-106/300\n
Interface0\hostName=bogopi
Interface0\interfaceClass=NetInterface
Interface0\passcode=21753
Interface0\port=14580

[StationSettings]
callsign=KM5VY-14
comment=
group=@Variant(\0\0\0\a\0\0)
hasPHG=false
lat=@Variant(\0\0\0\x87\0\0\0\0)
lon=@Variant(\0\0\0\x87\0\0\0\0)
symbol=@Variant(\0\0\0\a\0X)

@tvrusso
Copy link
Member

tvrusso commented Mar 12, 2020

Oh, yeah. stationconfiguration doesn't even look at the lat/lon setting in the dialog. It never actually gets set. There are no hooks in the UI to update anything if you enter data in the dialog for lat/lon. There's a comment there that makes it look like it just got left out to be figured out later.

So it makes sense that nothing gets saved --- the lat/lon part of the station settings is never set anywhere. This is not likely to get changed much unless someone is inspired to start working on Xastir-Qt again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants