Remove unnecessary precondition checks #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public constructors prevent the object from being in this state. Signed-off-by: Bradley Grainger <[email protected]>
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2129 +/- ##
==========================================
- Coverage 64.23% 64.12% -0.11%
==========================================
Files 248 248
Lines 8396 8340 -56
Branches 592 584 -8
==========================================
- Hits 5393 5348 -45
+ Misses 2852 2844 -8
+ Partials 151 148 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adamsitnik
reviewed
Dec 18, 2023
Co-authored-by: Adam Sitnik <[email protected]>
adamsitnik
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Code clean up from #2096 (comment).
The public constructors prevent the object from being in this state.
Does this PR introduce a user-facing change?:
No.
Please make sure you've completed the relevant tasks for this PR, out of the following list: