-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenID Connect - Validate Discovery Endpoint response #1981
Conversation
Thanks for any suggestions and feedback 😄 |
src/HealthChecks.OpenIdConnectServer/DiscoveryEndpointResponse.cs
Outdated
Show resolved
Hide resolved
Looks good thought I have not read the spec. |
Co-authored-by: Ivan Maximov <[email protected]>
src/HealthChecks.OpenIdConnectServer/DiscoveryEndpointResponse.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.OpenIdConnectServer/DiscoveryEndpointResponse.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.OpenIdConnectServer/DiscoveryEndpointResponse.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.OpenIdConnectServer/DiscoveryEndpointResponse.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.OpenIdConnectServer/DiscoveryEndpointResponse.cs
Outdated
Show resolved
Hide resolved
I would like to add tests for validation. |
Reminder - bump version. |
I've added applied code suggestions, added unit tests and bumped the version. I decided to write more sophisticated check for cc @sungam3r |
src/HealthChecks.OpenIdConnectServer/DiscoveryEndpointResponse.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.OpenIdConnectServer/HealthChecks.OpenIdConnectServer.csproj
Outdated
Show resolved
Hide resolved
Thanks, cc @sungam3r |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1981 +/- ##
==========================================
+ Coverage 66.19% 66.49% +0.30%
==========================================
Files 253 253
Lines 8726 8728 +2
Branches 627 626 -1
==========================================
+ Hits 5776 5804 +28
+ Misses 2785 2760 -25
+ Partials 165 164 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What this PR does / why we need it:
Which issue(s) this PR fixes:
closes #701
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: