feat: Support Dynamic NFT #1525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnxie999
reviewed
Jul 10, 2024
4 tasks
shawnxie999
reviewed
Jul 19, 2024
cindyyan317
commented
Jul 23, 2024
| @@ -28,7 +28,8 @@ class Clio(ConanFile): | |||
| 'protobuf/3.21.9', | |||
| 'grpc/1.50.1', | |||
| 'openssl/1.1.1u', | |||
| 'xrpl/2.3.0-b1', | |||
There was a problem hiding this comment.
Please ignore this change. DNFT will be merged after libxrpl gets updated.
cindyyan317
commented
Jul 23, 2024
kuznetsss
reviewed
Jul 24, 2024
cindyyan317
force-pushed
the
DNFT
branch
2 times, most recently
from
85e33fd
to
a6b7569
Compare
shawnxie999
reviewed
Aug 7, 2024
| if (maybeNFT) { | ||
| if (maybeNFT->onlyUriChanged) { | ||
| nfTokenURIChanges.push_back(*maybeNFT); | ||
| } else { |
kuznetsss
reviewed
Aug 16, 2024
|
After XRPLF/rippled#5048 is merged, we can merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clio's changes for supporting DNFT https://github.com/XRPLF/rippled/pull/5048/files