Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timesteps different from the original BFL's implementation? #114

Open
dkenw opened this issue Sep 19, 2024 · 0 comments
Open

Timesteps different from the original BFL's implementation? #114

dkenw opened this issue Sep 19, 2024 · 0 comments

Comments

@dkenw
Copy link

dkenw commented Sep 19, 2024

Implementation in XLabs' x-flux:

timesteps = get_schedule(
num_steps,
(width // 8) * (height // 8) // (16 * 16),
shift=True,
)

For an image of 1024x1024, the image_seq_len passed to get_schedule is set to 64.

Implementation in BFL's flux:

https://github.com/black-forest-labs/flux/blob/87f6fff727a377ea1c378af692afb41ae84cbe04/src/flux/cli.py#L197

timesteps = get_schedule(opts.num_steps, inp["img"].shape[1], shift=(name != "flux-schnell"))

For an image of 1024x1024, the image_seq_len passed to get_schedule is set to 4096. This seems to be more correct in theory. So, is that a bug in your codebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant