Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading an exported modlist with only NOT subscribed items doesn't let you download them #334

Open
BinaryTiger opened this issue Nov 21, 2022 · 1 comment
Labels
Severity: Low Status: Accepted Confirmed bug or useful feature that should be worked on. Type: Bug

Comments

@BinaryTiger
Copy link

AML Version:
1.5.0

Description
Profile Tab > Load button

If using a list that contains only mods that aren't in the active mod list, the load button will show a "No mods found, bad profile?" dialog. If at least one item in the .txt is in the active mod list, it will show a dialog prompting to download the missing mods.

I'm expecting the "download missing mod?" dialog to appear, even when all mod in the .txt are missing. This scenario occurs when installing AML and xcom2 on an account without any subscribed mods in steam.

Workaround
Subscribe and download at least one of the mod from the list manually, then redo the load process.

Fix breadcrumbs

This happens because there's a check for activeMods that can stop the whole process before the check for missing mods is done.

@BinaryTiger BinaryTiger added Status: Review Verify bug or check feasibility of a new feature. Type: Bug labels Nov 21, 2022
@RevZero
Copy link
Member

RevZero commented Nov 22, 2022

Thanks for reporting. The import/export stuff is all legacy code that I barely looked at before. But from a quick glance it should suffice to move the if (activeMods.Count == 0) check below the if (missingMods.Count > 0) section, as you already pointed out.

@RevZero RevZero added Status: Accepted Confirmed bug or useful feature that should be worked on. Severity: Low and removed Status: Review Verify bug or check feasibility of a new feature. labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: Low Status: Accepted Confirmed bug or useful feature that should be worked on. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants