Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyrillic descriptions aren't updated correctly #280

Open
EricKotato opened this issue Sep 16, 2021 · 1 comment
Open

Cyrillic descriptions aren't updated correctly #280

EricKotato opened this issue Sep 16, 2021 · 1 comment
Assignees
@RevZero
Labels
Status: Accepted Confirmed bug or useful feature that should be worked on. Type: Enhancement
Milestone
v1.6

Comments

@EricKotato
Copy link

EricKotato commented Sep 16, 2021 •
edited
Loading

AML Version: 1.5.0-beta, 1.5.0-beta.2

Description
Even though #215 was resolved for Cyrillic mod titles, descriptions are still using wrong encoding until they're deleted and installed again.

Screenshots

Before unsubscribing, deleting mod entry, and subscribing again (title is fine, description is not):

After unsubscribing, deleting mod entry, and subscribing again (both title and description are fine):
@EricKotato EricKotato added Status: Review Verify bug or check feasibility of a new feature. Type: Bug labels Sep 16, 2021
@EricKotato EricKotato changed the title Cyrillic descriptions still aren't updated Cyrillic descriptions aren't updated correctly Sep 16, 2021
@RevZero
Copy link
Member

RevZero commented Sep 16, 2021

It is by design, that the description is not updated each time the mod is updated. The reasoning behind that is, that it is possible to edit the description (to leave a compatibility note or something) and you would not want to have it overwritten each time.

While the mod name can also be edited, it is implemented slightly different. AML remembers if the mod name has been manually edited. If not, it will be updated each time the mod is updated, otherwise the name will stay customized.

It would probably make sense to have the mod description behave similarly. But that would be kind of a breaking change, because AML would silently overwrite potentially edited mod descriptions.

@RevZero RevZero added this to the v1.6 milestone Aug 17, 2023
@RevZero RevZero added Type: Enhancement Status: Accepted Confirmed bug or useful feature that should be worked on. and removed Type: Bug Status: Review Verify bug or check feasibility of a new feature. labels Aug 17, 2023
@RevZero RevZero self-assigned this Aug 17, 2023
RevZero added a commit that referenced this issue Jul 5, 2024
@RevZero
Added support to make notes for each mod.
2340cc5 
- Notes can be edited from the new note tab in mod info panel or using the note column in the mod list view (column is hidden by default).
- Mod description is no longer editable.
- Mod description now gets properly updated, not only in case it is empty. Fixes #280. This will (obviously) overwrite all manual changes made to the description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RevZero RevZero

Labels
Status: Accepted Confirmed bug or useful feature that should be worked on. Type: Enhancement
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests
2 participants
@RevZero @EricKotato