Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCO conflicts are not detected if XComEngine.ini is in a subfolder #249

Open
Iridar opened this issue Jan 8, 2021 · 2 comments
Open

MCO conflicts are not detected if XComEngine.ini is in a subfolder #249

Iridar opened this issue Jan 8, 2021 · 2 comments
Labels
Status: Implemented Indicates that the issue has been handled but may not have been merged. Type: Enhancement
Milestone
v1.6

Comments

@Iridar
Copy link

Iridar commented Jan 8, 2021

For example, Config\Base\XComEngine.ini.

My XSkin mod has conflicting mod class overrides with Remove Weapon Upgrades, but AML doesn't highlight them.
@RevZero RevZero added the Status: Review Verify bug or check feasibility of a new feature. label Jan 8, 2021
@RevZero
Copy link
Member

RevZero commented Apr 12, 2021

Currently, AML only looks for Config\XComEngine.ini. Should AML scan all sub-folders as well? Does X2 care if the file is not in Config?

@robojumper
Copy link
Member

The game parses all config files in Config and its recursive subdirectories, so AML should probably do that as well.

@RevZero RevZero added Type: Enhancement Status: Accepted Confirmed bug or useful feature that should be worked on. and removed Status: Review Verify bug or check feasibility of a new feature. labels Aug 14, 2023
@RevZero RevZero added this to the v1.6 milestone Aug 14, 2023
remcoros added a commit to remcoros/xcom2-launcher that referenced this issue Aug 14, 2023
@remcoros
read all XComEngine.ini files from the Config folder when reading MCOs
ad07bbd 
fixes X2CommunityCore#249
@remcoros remcoros mentioned this issue Aug 14, 2023
Merged
RevZero pushed a commit that referenced this issue Aug 17, 2023
@remcoros
Consider XComEngine.ini files from Config sub-folders when reading MC…
51bd0c1 
…Os (#348)

Fixes #249
@RevZero RevZero added Status: Implemented Indicates that the issue has been handled but may not have been merged. and removed Status: Accepted Confirmed bug or useful feature that should be worked on. labels Aug 17, 2023
RevZero pushed a commit that referenced this issue Jul 5, 2024
@remcoros @RevZero
Consider XComEngine.ini files from Config sub-folders when reading MC…
8644629 
…Os (#348)

Fixes #249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Implemented Indicates that the issue has been handled but may not have been merged. Type: Enhancement
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests
3 participants
@RevZero @Iridar @robojumper