Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1111 - Add localisation to Options menu for Shen's Last Gift #1204

Conversation

BlackDog86
Copy link
Contributor

@BlackDog86 BlackDog86 commented Jun 24, 2023

Fixes #1111

"Shen's Last Gift" appears as "DLC_3" in the options menu. This PR adds some localisation text to all languages & mouseover text for all languages except CHN/CHT/KOR/JPN as I'm not familiar enough with the characters in these languages to add or remove stuff without (probably) completely changing the meaning. No attention has been given to whether the slider actually does anything or not in-game (all text assumes that the slider increases the chances of getting cosmetic SPARK options from the DLC in the same way as the other sliders).

…as "Shen's Last Gift" in the options menu. Added mouseover text for all languages except CHN/CHT/KOR/JPN as I'm not familiar enough with the characters in these languages to add or remove stuff without (probably) completely changing the meaning.
@BlackDog86 BlackDog86 changed the title Issue #1111 - Add localisation options in Options menu for Shen's Last Gift Issue #1111 - Add localisation to Options menu for Shen's Last Gift Jun 24, 2023
@Iridar
Copy link
Contributor

Iridar commented Jun 24, 2023

I appreciate your enthusiasm, but the slight problem with this is this is the main Highlander is technically not the proper place to do it. If we had a Shen's Last Gift Highlander, that's where this should have gone. Until then, the best place for a fix like that is in some less strict community bugfix mod, such as the Core Collection Meta Mod.

On the other hand, this is just localization, and not a code change, and will have literally no impact if the user doesn't have SLG, so maybe it's not a big deal?

@Iridar Iridar added the ready-to-review A pull request is ready to be reviewed label Jun 24, 2023
@Iridar Iridar modified the milestones: 1.25.0, 1.26.0 Jun 24, 2023
@Iridar
Copy link
Contributor

Iridar commented Jun 29, 2023

Yeah, sorry, even if it's just a localization change, I don't want to set the precedent of adding things that are relevant only to a DLC into main Highlander. If ever have a Highlander for Shen's Last Gift, we'll fix it there. Until then, I'll fix it in Core Collection Meta Mod.

@Iridar Iridar closed this Jun 29, 2023
@Iridar Iridar added dlc3 Regarding Shen's Last Gift and removed ready-to-review A pull request is ready to be reviewed labels Aug 19, 2023
@Iridar Iridar removed this from the 1.26.0 milestone Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dlc3 Regarding Shen's Last Gift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shen's Last Gift cosmetic options slider is displayed as "DLC_3"
2 participants