-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hosting Landing Page #199
Comments
This is ready for initial designer review @WordPress/meta-design . Including screenshots below. If you want to preview the page, it can be previewed at https://wordpress.org/hosting-2/ by clicking preview in the editor. Thank you.
|
Thanks @bengreeley! When I preview at https://wordpress.org/hosting-2/ by clicking preview in the editor, I still see the dark header and footer. However, from your screenshots, it looks great to me. The only comment I have is there should also be a border on the header as well:
|
A tangential question: do we need the adminbar here? I feel like we should default to not showing it unless there's a good reason to include it. |
Thank you both for taking a look! @jasmussen I can't see a reason to have the admin bar. I'll look to have that removed when the page is launched. @beafialho Thanks for pointing out that line, I totally missed that. I'll update it and get final approvals/launch with the changes. |
@beafialho Should that border be on the white global header itself (for all pages that use the white header), or is that specific to the hosting page? For example, we don't have that on the Download page. |
Thanks for checking that detail out @ryelle. This border should be on the white global header whenever the background is also white. Same for the footer. The thinking here is, whenever the header background is the same color as the cover background, there should be a border to act as a visual mark. Another example: if the header was black and the cover was black as well, there should be a White border with opacity between them. Does that make sense? I also added the border details to the WP.org Design Library. |
That makes sense. Can you add an issue to https://github.com/WordPress/wporg-mu-plugins/ for that update? |
Sure, I'll add it. |
Note: siteground was removed.
|
@StevenDufresne & @renintw circling back to this issue. Is it correct to assume that any additional changes can be made directly to the page that Ben created (/hosting-2), and then once finalized, will be turned into a template/pattern to replace the existing page (/hosting)? Or is there a better approach for this? |
Correct! Ben's PR has the base changes required. |
Figma Design
Current hosting URL
This should be done as a template and pattern, similar to #157
The text was updated successfully, but these errors were encountered: