Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hosting Landing Page #199

Open
bengreeley opened this issue Feb 9, 2023 · 11 comments · May be fixed by #203
Open

Add Hosting Landing Page #199

bengreeley opened this issue Feb 9, 2023 · 11 comments · May be fixed by #203
Labels
[Component] Content Bugs or issues related to the page content [Status] Needs Copy Feedback Content needs to be written or updated

Comments

@bengreeley
Copy link

Figma Design
Current hosting URL

Desktop Mobile
Landing - Desktop Landing - Mobile
   |

This should be done as a template and pattern, similar to #157

@bengreeley
Copy link
Author

bengreeley commented Feb 9, 2023

This is ready for initial designer review @WordPress/meta-design . Including screenshots below. If you want to preview the page, it can be previewed at https://wordpress.org/hosting-2/ by clicking preview in the editor. Thank you.

Desktop Mobile
desktop mobile

@beafialho
Copy link

Thanks @bengreeley! When I preview at https://wordpress.org/hosting-2/ by clicking preview in the editor, I still see the dark header and footer. However, from your screenshots, it looks great to me.

The only comment I have is there should also be a border on the header as well:

Preview Design
Captura de ecrã 2023-02-10, às 14 27 16 Captura de ecrã 2023-02-10, às 14 27 50

@jasmussen
Copy link
Contributor

A tangential question: do we need the adminbar here? I feel like we should default to not showing it unless there's a good reason to include it.

@bengreeley
Copy link
Author

Thank you both for taking a look!

@jasmussen I can't see a reason to have the admin bar. I'll look to have that removed when the page is launched.

@beafialho Thanks for pointing out that line, I totally missed that. I'll update it and get final approvals/launch with the changes.

@ryelle
Copy link
Contributor

ryelle commented Feb 13, 2023

@beafialho Should that border be on the white global header itself (for all pages that use the white header), or is that specific to the hosting page? For example, we don't have that on the Download page.

@beafialho
Copy link

Thanks for checking that detail out @ryelle. This border should be on the white global header whenever the background is also white. Same for the footer.

The thinking here is, whenever the header background is the same color as the cover background, there should be a border to act as a visual mark. Another example: if the header was black and the cover was black as well, there should be a White border with opacity between them. Does that make sense?

I also added the border details to the WP.org Design Library.

@ryelle
Copy link
Contributor

ryelle commented Feb 13, 2023

That makes sense. Can you add an issue to https://github.com/WordPress/wporg-mu-plugins/ for that update?

@beafialho
Copy link

Sure, I'll add it.

@adamwoodnz adamwoodnz linked a pull request Feb 13, 2023 that will close this issue
@ryelle ryelle added [Component] Content Bugs or issues related to the page content [Status] Needs Copy Feedback Content needs to be written or updated labels May 4, 2023
@StevenDufresne
Copy link
Contributor

Note: siteground was removed.

  • Remove siteground

@ndiego
Copy link
Member

ndiego commented Nov 1, 2023

@StevenDufresne & @renintw circling back to this issue. Is it correct to assume that any additional changes can be made directly to the page that Ben created (/hosting-2), and then once finalized, will be turned into a template/pattern to replace the existing page (/hosting)? Or is there a better approach for this?

@adamwoodnz
Copy link
Contributor

Is it correct to assume that any additional changes can be made directly to the page that Ben created (/hosting-2), and then once finalized, will be turned into a template/pattern to replace the existing page

Correct! Ben's PR has the base changes required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Content Bugs or issues related to the page content [Status] Needs Copy Feedback Content needs to be written or updated
Projects
Status: 🛑 Pending discussion
Development

Successfully merging a pull request may close this issue.

7 participants