Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Book and Podcast hero pattern from using h2 to h1 #380

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Update Book and Podcast hero pattern from using h2 to h1 #380

wants to merge 2 commits into from
+4 −4

Conversation

melchoyce
Copy link

Description

The Book and Podcast landing page patterns were both missing an h1. I've updated the hero patterns to use h1 instead of h2.

Fixes #369.

Screenshots

No visual change.

Testing Instructions

  1. Ensure the theme is active
  2. Add a new page
  3. Select the Book or Podcast landing page patterns
  4. Ensure the hero pattern at the top is using an h1 instead of h2

@github-actions GitHub Actions
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @melchoyce.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: melchoyce.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: ddewan-git <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@melchoyce melchoyce added [Component] Block Patterns Accessibility (a11y) Needs accessibility testing or feedback labels Sep 20, 2024
carolinan
carolinan reviewed Sep 21, 2024
View reviewed changes
patterns/hero-podcast.php
<!-- wp:heading {"fontSize":"xx-large"} -->
<h2 class="wp-block-heading has-xx-large-font-size">The Stories Podcast</h2>
<!-- wp:heading {"level":1,"fontSize":"xx-large"} -->
<h1 class="wp-block-heading has-xx-large-font-size">The Stories Podcast</h1>
<!-- /wp:heading -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading below this "Subscribe to..." needs to be updated from H3 to H2, so that the H2 level is not skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan left review comments

Assignees
No one assigned
Labels
Accessibility (a11y) Needs accessibility testing or feedback [Component] Block Patterns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

H1 missing in landing page patterns
2 participants
@melchoyce @carolinan