Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Make footers translatable. #372

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Enhancement: Make footers translatable. #372

merged 2 commits into from
Sep 23, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Sep 19, 2024

Description

I am adding i18n functions for footers.

I'm still doubtful we should include Twenty Twenty-Five as a hardcoded string in some footers. I know this discussion happened before. I believe that now that we have the copyright block binding, that's a good candidate. Else, re-consider the site title.

Screenshots

N/A

Testing Instructions

  1. Open the site editor
  2. Try every footer
  3. Check that the strings are correct.

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Sep 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

I agree that the theme name should not be in the footer. It is common in commercial themes, but in this case, I don't think WordPress needs to strengthen the "Twenty Twenty-Five" name, and the WordPress credit is already in the footer. But I'm not a marketer.

@carolinan
Copy link
Contributor

This can be merged, if we want to handle the theme name text in a separate issue.

@juanfra
Copy link
Member Author

juanfra commented Sep 23, 2024

Thanks, @carolinan. I believe we can keep that discussion on an issue to hear different perspectives and merge this one.

@juanfra juanfra merged commit a2e4667 into trunk Sep 23, 2024
5 checks passed
@juanfra juanfra deleted the fix/footers-i18n branch September 23, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants