-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Make footers translatable. #372
Conversation
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I agree that the theme name should not be in the footer. It is common in commercial themes, but in this case, I don't think WordPress needs to strengthen the "Twenty Twenty-Five" name, and the WordPress credit is already in the footer. But I'm not a marketer. |
This can be merged, if we want to handle the theme name text in a separate issue. |
Thanks, @carolinan. I believe we can keep that discussion on an issue to hear different perspectives and merge this one. |
Description
I am adding i18n functions for footers.
I'm still doubtful we should include
Twenty Twenty-Five
as a hardcoded string in some footers. I know this discussion happened before. I believe that now that we have the copyright block binding, that's a good candidate. Else, re-consider the site title.Screenshots
N/A
Testing Instructions