-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Morning style variation. #261
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b65e8d3
Add morning style variation.
juanfra 54535ad
Add rem values.
juanfra e574042
Update site tagline font size to match design.
juanfra 5850ded
Remove heading sizes.
juanfra e88b3ea
Merge branch 'trunk' into try/add-morning-style-variation
juanfra 1cc2227
Update font-weight for post title.
juanfra 0762d21
Set button border-radius to 0
juanfra 5e8804d
Merge branch 'trunk' into try/add-morning-style-variation
carolinan bae9abb
Apply suggestions from the code review.
juanfra cae2a95
Rename file.
juanfra 2e1918b
Use medium font size preset for cite.
juanfra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,338 @@ | ||
| { | ||
| "$schema": "https://schemas.wp.org/trunk/theme.json", | ||
| "version": 3, | ||
| "title": "Morning", | ||
| "settings": { | ||
| "color": { | ||
| "palette": [ | ||
| { | ||
| "color": "#DFDCD7", | ||
| "name": "Base", | ||
| "slug": "base" | ||
| }, | ||
| { | ||
| "color": "#191919", | ||
| "name": "Contrast", | ||
| "slug": "contrast" | ||
| }, | ||
| { | ||
| "color": "#7A9BDB", | ||
| "name": "Accent 1", | ||
| "slug": "accent-1" | ||
| }, | ||
| { | ||
| "color": "#F7E6FF", | ||
| "name": "Accent 2", | ||
| "slug": "accent-2" | ||
| }, | ||
| { | ||
| "color": "#182949", | ||
| "name": "Accent 3", | ||
| "slug": "accent-3" | ||
| }, | ||
| { | ||
| "color": "#5F5F5F", | ||
| "name": "Primary", | ||
| "slug": "primary" | ||
| }, | ||
| { | ||
| "color": "#D7D3CC", | ||
| "name": "Secondary", | ||
| "slug": "secondary" | ||
| }, | ||
| { | ||
| "color": "#19191933", | ||
| "name": "Opacity 20%", | ||
| "slug": "opacity-20" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "styles": { | ||
| "color": { | ||
| "text": "var:preset|color|primary" | ||
| }, | ||
| "typography": { | ||
| "fontFamily": "var:preset|font-family|ysabeau-office", | ||
| "fontSize": "1.5rem", | ||
| "fontStyle": "normal", | ||
| "fontWeight": "400", | ||
| "letterSpacing": "-0.24px", | ||
| "lineHeight": "1.5" | ||
| }, | ||
| "blocks": { | ||
| "core/button": { | ||
| "variations": { | ||
| "outline": { | ||
| "border": { | ||
| "color": "currentColor" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "core/code": { | ||
| "color": { | ||
| "text": "var:preset|color|contrast", | ||
| "background": "var:preset|color|secondary" | ||
| } | ||
| }, | ||
| "core/navigation": { | ||
| "typography": { | ||
| "fontSize": "1.25rem" | ||
| } | ||
| }, | ||
| "core/paragraph": { | ||
| "elements": { | ||
| "link": { | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "core/post-author-name": { | ||
| "typography": { | ||
| "fontSize": "var:preset|font-size|medium" | ||
| }, | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "elements": { | ||
| "link": { | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "typography": { | ||
| "textDecoration": "underline" | ||
| }, | ||
| ":hover": { | ||
| "typography": { | ||
| "textDecoration": "none" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "core/post-terms": { | ||
| "typography": { | ||
| "fontWeight": "400", | ||
| "fontSize": "var:preset|font-size|medium" | ||
| }, | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "elements": { | ||
| "link": { | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "typography": { | ||
| "textDecoration": "underline" | ||
| }, | ||
| ":hover": { | ||
| "typography": { | ||
| "textDecoration": "none" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "core/post-title": { | ||
| "typography": { | ||
| "fontWeight": "900", | ||
| "letterSpacing": "-0.96px" | ||
| }, | ||
| "elements": { | ||
| "link": { | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "core/pullquote": { | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "typography": { | ||
| "fontSize": "var:preset|font-size|x-large", | ||
| "letterSpacing": "-0.76px" | ||
| }, | ||
| "elements": { | ||
| "cite": { | ||
| "typography": { | ||
| "fontSize": "var:preset|font-size|medium", | ||
| "letterSpacing": "-0.14px" | ||
| }, | ||
| "color": { | ||
| "text": "var:preset|color|primary" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "core/quote": { | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "typography": { | ||
| "fontSize": "1.5rem", | ||
| "fontWeight": "500", | ||
| "letterSpacing": "-0.18px" | ||
| }, | ||
| "elements": { | ||
| "cite": { | ||
| "typography": { | ||
| "fontSize": "var:preset|font-size|medium", | ||
| "fontWeight": "300", | ||
| "letterSpacing": "-0.14px" | ||
| }, | ||
| "color": { | ||
| "text": "var:preset|color|primary" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "core/site-tagline": { | ||
| "typography": { | ||
| "fontSize": "var:preset|font-size|large" | ||
| } | ||
| }, | ||
| "core/site-title": { | ||
| "typography": { | ||
| "fontFamily": "var:preset|font-family|ysabeau-office", | ||
| "fontSize": "var:preset|font-size|large", | ||
| "fontWeight": "700", | ||
| "textTransform": "uppercase" | ||
| } | ||
| } | ||
| }, | ||
| "elements": { | ||
| "button": { | ||
| "typography": { | ||
| "fontFamily": "var:preset|font-family|literata", | ||
| "fontSize": "1.375rem", | ||
| "fontWeight": "900", | ||
| "letterSpacing": "-0.36px" | ||
| }, | ||
| "color": { | ||
| "text": "var:preset|color|contrast", | ||
| "background": "var:preset|color|accent-1" | ||
| }, | ||
| "border":{ | ||
| "color": "var:preset|color|accent-1", | ||
| "radius": "0px" | ||
| } | ||
| }, | ||
| "heading": { | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "typography": { | ||
| "fontFamily": "var:preset|font-family|literata", | ||
| "fontWeight": "900" | ||
| } | ||
| }, | ||
| "link": { | ||
| "color": { | ||
| "text": "var:preset|color|contrast" | ||
| } | ||
| } | ||
| }, | ||
| "variations": { | ||
| "post-terms-1": { | ||
| "typography": { | ||
| "fontSize": "16px" | ||
| }, | ||
| "elements": { | ||
| "link": { | ||
| "color": { | ||
| "background": "var:preset|color|secondary" | ||
| }, | ||
| "border": { | ||
| "radius": "100px", | ||
| "color": "var:preset|color|secondary" | ||
| }, | ||
| "typography": { | ||
| "textDecoration": "none" | ||
| }, | ||
| ":hover": { | ||
| "typography": { | ||
| "textDecoration": "underline" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "section-1": { | ||
| "elements": { | ||
| "button": { | ||
| "color": { | ||
| "background": "var:preset|color|accent-1", | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "border": { | ||
| "color": "var:preset|color|accent-1" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "section-2": { | ||
| "color": { | ||
| "text": "var:preset|color|base" | ||
| }, | ||
| "elements": { | ||
| "heading": { | ||
| "color": { | ||
| "text": "var:preset|color|base" | ||
| } | ||
| }, | ||
| "button": { | ||
| "color": { | ||
| "background": "var:preset|color|accent-2", | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "border": { | ||
| "color": "var:preset|color|accent-2" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "section-3": { | ||
| "elements": { | ||
| "button": { | ||
| "color": { | ||
| "background": "var:preset|color|accent-2", | ||
| "text": "var:preset|color|contrast" | ||
| }, | ||
| "border": { | ||
| "color": "var:preset|color|accent-2" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "section-4": { | ||
| "elements": { | ||
| "heading": { | ||
| "color": { | ||
| "text": "var:preset|color|base" | ||
| } | ||
| }, | ||
| "button": { | ||
| "border": { | ||
| "color": "var:preset|color|base" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "section-5": { | ||
| "elements": { | ||
| "button": { | ||
| "border": { | ||
| "color": "var:preset|color|contrast" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be hardcoded? Is there no matching responsive preset size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no preset for 16px, which is the size of the font size for this particular element in the variation. We have
--wp--preset--font-size--normalfrom Gutenberg, which is 16px, but we can't use that.If we don't want to hardcode the value, we could use medium (18px) or small (14px) alternatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd always go for the larger :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we run this by Bea once she's back?