-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The borders of the quote block are not visible for some color variations and sections. #653
Comments
I'm working on this and will submit the PR once I receive confirmation from the maintainer. |
Does the border even need a color defined? If it is not defined it will always inherit the text color. |
Yes, you’re correct. Removing the color attribute should fix this issue. |
However, I discovered additional issues with the Sunrise style. It is overriding the color, border-color, and some other attributes. This creates visibility problems due to the accent-2 color. Additionally, the pullquote block is experiencing the same issue. |
Yes the text color problem is more serious, the border is not necessary for understanding the content. |
Closed as fixed with #619 |
Description
The borders of the quote block are not clearly visible with certain color themes and in different sections.
For the default color theme, the borders appear fine, but when I switch to a different color theme or change the section color, they become hard to see. The borders should be visible across all themes. It looks like this block is using the contrast color for the border, but I think it would be better to use the
currentColor
instead.Expected behavior
The borders should be visible across all themes.
Reproduction Instructions:
Screenshots
The text was updated successfully, but these errors were encountered: