Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The borders of the quote block are not visible for some color variations and sections. #653

Closed
alaminfirdows opened this issue Oct 29, 2024 · 6 comments
Labels
[Type] Bug An existing feature does not function as intended.

Comments

@alaminfirdows
Copy link
Contributor

Description
The borders of the quote block are not clearly visible with certain color themes and in different sections.

For the default color theme, the borders appear fine, but when I switch to a different color theme or change the section color, they become hard to see. The borders should be visible across all themes. It looks like this block is using the contrast color for the border, but I think it would be better to use the currentColor instead.

Expected behavior
The borders should be visible across all themes.

Reproduction Instructions:

  1. Start by creating a new page or post.
  2. Add a "Group" block and apply "Section Style 5" to it.
  3. Within this group, insert a "Quote" block.
  4. Preview the page or post.

Screenshots
Image
Image

@alaminfirdows alaminfirdows added the [Type] Bug An existing feature does not function as intended. label Oct 29, 2024
@alaminfirdows
Copy link
Contributor Author

I'm working on this and will submit the PR once I receive confirmation from the maintainer.

@carolinan
Copy link
Contributor

Does the border even need a color defined? If it is not defined it will always inherit the text color.

@alaminfirdows
Copy link
Contributor Author

Yes, you’re correct. Removing the color attribute should fix this issue.

@alaminfirdows
Copy link
Contributor Author

However, I discovered additional issues with the Sunrise style. It is overriding the color, border-color, and some other attributes. This creates visibility problems due to the accent-2 color.

Additionally, the pullquote block is experiencing the same issue.

./twentytwentyfive/styles/07-sunrise.json
Image

@carolinan
Copy link
Contributor

Yes the text color problem is more serious, the border is not necessary for understanding the content.

@juanfra
Copy link
Member

juanfra commented Nov 4, 2024

Closed as fixed with #619

@juanfra juanfra closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
3 participants