Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dusk: Annotation vertical padding looks uneven #605

Open
juanfra opened this issue Oct 21, 2024 · 7 comments
Open

Dusk: Annotation vertical padding looks uneven #605

juanfra opened this issue Oct 21, 2024 · 7 comments
Labels
[Type] Bug An existing feature does not function as intended.

Comments

@juanfra
Copy link
Member

juanfra commented Oct 21, 2024

Description

The annotation style in the dusk variation looks a bit uneven. It looks like it has more padding-bottom.

Step-by-step reproduction instructions

  1. Activate dusk.
  2. Try out a pattern including the annotation style, or the "Photo blog home"
  3. Confirm that the annotation style is looking uneven.

Screenshots

Image

@juanfra juanfra added the [Type] Bug An existing feature does not function as intended. label Oct 21, 2024
@carolinan
Copy link
Contributor

I can reproduce this, I think it may just be a typo:
I think the bottom padding should just be 0.2rem

    padding-top: 0.2rem;
    padding-right: 0.6rem;
    padding-bottom: 0.25rem;
    padding-left: 0.6rem;

@carolinan
Copy link
Contributor

But it may be better to only update it for this style variation.

@carolinan
Copy link
Contributor

Meh, now when I have switched computer, 0.2rem is also too large, and I need to set it to 0 bottom padding for the text to align. 🤷‍♀

@carolinan
Copy link
Contributor

Ignore me, it is the same on both the mac (small screen resolution) and PC (large screen resolution), when 0.2 rem is used, the text is still miss-aligned.

@troychaplin
Copy link
Contributor

@carolinan setting the padding bottom to 0.2rem seems to be fine, at least to me. Top example is 0.2, while bottom is original of 0.25

Image

@juanfra
Copy link
Member Author

juanfra commented Oct 22, 2024

@troychaplin It looks like the problem is with the headings' typography. The paragraph is using Fira sans, and it seems to work fine there. It looks off when the annotation is applied to a heading (using Vollkorn) like the one we have for the home page.

Screen.Recording.2024-10-22.at.15.34.24.mov

@troychaplin
Copy link
Contributor

Removing me as assignee in case someone else wants to take a look and has another approach to solving this issue. Notes around what has been attempted to date can be seen in close PR #636

@troychaplin troychaplin removed their assignment Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

No branches or pull requests

3 participants