-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dusk: Annotation vertical padding looks uneven #605
Comments
I can reproduce this, I think it may just be a typo:
|
But it may be better to only update it for this style variation. |
Meh, now when I have switched computer, 0.2rem is also too large, and I need to set it to 0 bottom padding for the text to align. 🤷♀ |
Ignore me, it is the same on both the mac (small screen resolution) and PC (large screen resolution), when 0.2 rem is used, the text is still miss-aligned. |
@carolinan setting the padding bottom to 0.2rem seems to be fine, at least to me. Top example is 0.2, while bottom is original of 0.25 |
@troychaplin It looks like the problem is with the headings' typography. The paragraph is using Fira sans, and it seems to work fine there. It looks off when the annotation is applied to a heading (using Vollkorn) like the one we have for the home page. Screen.Recording.2024-10-22.at.15.34.24.mov |
Removing me as assignee in case someone else wants to take a look and has another approach to solving this issue. Notes around what has been attempted to date can be seen in close PR #636 |
Description
The annotation style in the dusk variation looks a bit uneven. It looks like it has more padding-bottom.
Step-by-step reproduction instructions
Screenshots
The text was updated successfully, but these errors were encountered: