Allow double underscores in index names #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks like a solid change.
All that remains is the question about the null coalescing operator and minimum supported PHP version .
brandonpayton
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
This looks good to me, and the unit tests pass. Thanks, @jeroenpf!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #133 (comment)
When creating new tables in SQLite, original index names are prefixed with the table name. This is because unlike MySQL, SQLite does not allow identical index names across the database. Adding a table prefix ensures the index names are unique.
When running a
show create tablequery, we restore the original index name by removing the table prefix. We split on double underscores but we did not take into account that the original index name can also contain__. This PR fixes an issue where we explode without a limit. We only want to explode on the first occurrence of__. Unit tests have been added to ensure this behavior.