-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed "exact match boost" implementation to use a match_phrase query in should #4975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd Sutori to the "Made with Openverse" page.
Fixed commit message to be more precise and include the issue number
Fixed commit message to be more precise and include the issue number
I added the suggestion from @sarayourfriend. Co-authored-by: sarayourfriend <[email protected]>
… in should #4960 I have added support for "match_pharse" and also removed variable quotes_stripped it's not needed now.
dryruffian
requested review from
krysal and
sarayourfriend
and removed request for
a team
September 23, 2024 16:34
openverse-bot
added
🧱 stack: api
Related to the Django API
🟩 priority: low
Low priority and doesn't need to be rushed
✨ goal: improvement
Improvement to an existing user-facing feature
💻 aspect: code
Concerns the software code in the repository
labels
Sep 23, 2024
…in should #4960 I have added support for "match_pharse" and also removed variable quotes_stripped it's not needed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💻 aspect: code
Concerns the software code in the repository
✨ goal: improvement
Improvement to an existing user-facing feature
🟩 priority: low
Low priority and doesn't need to be rushed
🧱 stack: api
Related to the Django API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4960 by @sarayourfriend
Description
This PR changes the
simple_query_string
query for boosting exact matches on the title to amatch_phrase
query, as suggested by @sarayourfriend. This change will save some parsing cycles in Elasticsearch and make our intention much clearer in code and in the generated query. I have also removedquotes_stripped
variable as its not needed anymore.Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin